Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zwave] Multilevel switch support (Dimmer and Curtains) #2061

Merged
merged 43 commits into from
May 13, 2024

Conversation

sescandell
Copy link
Contributor

@sescandell sescandell commented Apr 27, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
    - [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
    - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

This PR is to manage multilevel switch. These devices could have multiple purpose. It handles specific curtains and standard dimmers.

Dashboard
image

Intégration
image

Tested on real life devices with Fibaro Walli Roller Shutter & Fibaro Walli Dimmer

This update introduces a new way to add multiple features from the same zWave property. This is usefull for example to manage, with the same property (currentValue) two different features: a Dimmer and a Binary state. For Dimmers, turning the device ON executes a restorePrevious state (cloning real button behavior).

Copy link

relativeci bot commented Apr 27, 2024

#2546 Bundle Size — 10.13MiB (+0.05%).

3a75f91(current) vs 88e10e2 master#2542(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2546
     Baseline
#2542
Regression  Initial JS 5.45MiB(+0.09%) 5.44MiB
No change  Initial CSS 302.96KiB 302.96KiB
Change  Cache Invalidation 53.65% 53.58%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1479 1479
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2546
     Baseline
#2542
Regression  JS 7.23MiB (+0.07%) 7.22MiB
No change  IMG 2.46MiB 2.46MiB
No change  CSS 319.75KiB 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch sescandell:zwaveMultilevelSwitchProject dashboard

@sescandell sescandell changed the title [WIP][Zwave] Multilevel switch [WIP][Zwave] Multilevel switch support Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (a6569de) to head (3a75f91).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2061      +/-   ##
==========================================
+ Coverage   98.39%   98.40%   +0.01%     
==========================================
  Files         847      858      +11     
  Lines       13820    14038     +218     
==========================================
+ Hits        13598    13814     +216     
- Misses        222      224       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sescandell sescandell changed the title [WIP][Zwave] Multilevel switch support [Zwave] Multilevel switch support (Dimmer and Curtains) Apr 28, 2024
@William-De71
Copy link
Contributor

Thanks for checking the forum, I've added some comments about this PR.

https://community.gladysassistant.com/t/evolution-du-service-z-wave-js-ui/8692/38

@Pierre-Gilles Pierre-Gilles merged commit 69f6d03 into GladysAssistant:master May 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants