-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zwave] Multilevel switch support (Dimmer and Curtains) #2061
[Zwave] Multilevel switch support (Dimmer and Curtains) #2061
Conversation
#2546 Bundle Size — 10.13MiB (+0.05%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2546 |
Baseline #2542 |
|
---|---|---|
Initial JS | 5.45MiB (+0.09% ) |
5.44MiB |
Initial CSS | 302.96KiB |
302.96KiB |
Cache Invalidation | 53.65% |
53.58% |
Chunks | 51 |
51 |
Assets | 170 |
170 |
Modules | 1479 |
1479 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.82% |
0.82% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 1 change
1 regression
Current #2546 |
Baseline #2542 |
|
---|---|---|
JS | 7.23MiB (+0.07% ) |
7.22MiB |
IMG | 2.46MiB |
2.46MiB |
CSS | 319.75KiB |
319.75KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.53KiB |
17.53KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch sescandell:zwaveMultilevelSwitch Project dashboard
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2061 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 847 858 +11
Lines 13820 14038 +218
==========================================
+ Hits 13598 13814 +216
- Misses 222 224 +2 ☔ View full report in Codecov by Sentry. |
…previous known value from Gladys
… with an update of the widget (for another PR)
This reverts commit 89cd609.
…ment the restorePreviousState on multilevel switch.
a394a2e
to
41b949f
Compare
Thanks for checking the forum, I've added some comments about this PR. https://community.gladysassistant.com/t/evolution-du-service-z-wave-js-ui/8692/38 |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)- [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
This PR is to manage multilevel switch. These devices could have multiple purpose. It handles specific curtains and standard dimmers.
Dashboard
Intégration
Tested on real life devices with Fibaro Walli Roller Shutter & Fibaro Walli Dimmer
This update introduces a new way to add multiple features from the same zWave property. This is usefull for example to manage, with the same property (currentValue) two different features: a Dimmer and a Binary state. For Dimmers, turning the device ON executes a restorePrevious state (cloning real button behavior).