-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat blink light from switch device #2064
Feat blink light from switch device #2064
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2064 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 847 847
Lines 13820 13822 +2
=======================================
+ Hits 13598 13600 +2
Misses 222 222 ☔ View full report in Codecov by Sentry. |
#2519 Bundle Size — 10.08MiB (~+0.01%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2519 |
Baseline #2517 |
|
---|---|---|
Initial JS | 5.4MiB (~+0.01% ) |
5.4MiB |
Initial CSS | 303.21KiB |
303.21KiB |
Cache Invalidation | 53.45% |
53.45% |
Chunks | 51 |
51 |
Assets | 170 |
170 |
Modules | 1465 |
1465 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.82% |
0.82% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 1 change
1 regression
Current #2519 |
Baseline #2517 |
|
---|---|---|
JS | 7.18MiB (~+0.01% ) |
7.18MiB |
IMG | 2.46MiB |
2.46MiB |
CSS | 319.99KiB |
319.99KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.53KiB |
17.53KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch cicoub13:feat-blink-electric-plu... Project dashboard
6cc7b48
to
1abd427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me, thanks for the changes 🙏
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add ability to use switch (binary) devices in the action Blink Lights
Functional test in real life ✅ (done by @gboulvin)