Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat blink light from switch device #2064

Merged

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Apr 29, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add ability to use switch (binary) devices in the action Blink Lights

Functional test in real life ✅ (done by @gboulvin)

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (f90b143) to head (1abd427).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         847      847           
  Lines       13820    13822    +2     
=======================================
+ Hits        13598    13600    +2     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Apr 29, 2024

#2519 Bundle Size — 10.08MiB (~+0.01%).

1abd427(current) vs f90b143 master#2517(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2519
     Baseline
#2517
Regression  Initial JS 5.4MiB(~+0.01%) 5.4MiB
No change  Initial CSS 303.21KiB 303.21KiB
No change  Cache Invalidation 53.45% 53.45%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1465 1465
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2519
     Baseline
#2517
Regression  JS 7.18MiB (~+0.01%) 7.18MiB
No change  IMG 2.46MiB 2.46MiB
No change  CSS 319.99KiB 319.99KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch cicoub13:feat-blink-electric-plu...Project dashboard

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, thanks for the changes 🙏

@Pierre-Gilles Pierre-Gilles merged commit 6f0bc73 into GladysAssistant:master May 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants