Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee2mqtt : Keep keep_history when updating feature + fix update from devices with duplicate features #2072

Merged
merged 2 commits into from
May 9, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 9, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)

Description of change

Fix #2069 & #2060

Copy link

cloudflare-pages bot commented May 9, 2024

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 417b587
Status: ✅  Deploy successful!
Preview URL: https://e438de69.gladys-plus.pages.dev
Branch Preview URL: https://zigbee2mqtt-fix-update-bug.gladys-plus.pages.dev

View logs

Copy link

relativeci bot commented May 9, 2024

#2539 Bundle Size — 10.11MiB (0%).

417b587(current) vs cd825ab master#2536(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2539
     Baseline
#2536
No change  Initial JS 5.43MiB 5.43MiB
No change  Initial CSS 302.96KiB 302.96KiB
Change  Cache Invalidation 0% 63.03%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1478 1478
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2539
     Baseline
#2536
No change  JS 7.21MiB 7.21MiB
No change  IMG 2.46MiB 2.46MiB
No change  CSS 319.75KiB 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch zigbee2mqtt-fix-update-bugProject dashboard

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (cd825ab) to head (417b587).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         850      850           
  Lines       13907    13909    +2     
=======================================
+ Hits        13683    13685    +2     
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles merged commit 3bd6128 into master May 9, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the zigbee2mqtt-fix-update-bug branch May 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zigbee2mqtt: It seems that updating a device looses the "keep_history" setting
1 participant