Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cast integration #2088

Merged
merged 14 commits into from
Jun 10, 2024
Merged

Google Cast integration #2088

merged 14 commits into from
Jun 10, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 20, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

Description of change

Add support for Nest Mini speakers

Copy link

cloudflare-pages bot commented May 20, 2024

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b259ff
Status: ✅  Deploy successful!
Preview URL: https://b618d002.gladys-plus.pages.dev
Branch Preview URL: https://google-cast-integration.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (09a7987) to head (5b259ff).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2088   +/-   ##
=======================================
  Coverage   98.40%   98.41%           
=======================================
  Files         858      865    +7     
  Lines       14081    14162   +81     
=======================================
+ Hits        13857    13938   +81     
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review May 23, 2024 12:43
Copy link

relativeci bot commented May 23, 2024

#2597 Bundle Size — 10.18MiB (+0.41%).

07c115c(current) vs 09a7987 master#2576(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions
                 Current
#2597
     Baseline
#2576
Regression  Initial JS 5.48MiB(+0.53%) 5.46MiB
Regression  Initial CSS 303.12KiB(+0.05%) 302.96KiB
Change  Cache Invalidation 57.36% 63.14%
No change  Chunks 51 51
Change  Assets 171(+0.59%) 170
Change  Modules 1490(+0.68%) 1480
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 4 changes Regression 4 regressions
                 Current
#2597
     Baseline
#2576
Regression  JS 7.27MiB (+0.4%) 7.24MiB
Regression  IMG 2.48MiB (+0.5%) 2.46MiB
Regression  CSS 319.91KiB (+0.05%) 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 17.62KiB (+0.51%) 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch google-cast-integrationProject dashboard

@Pierre-Gilles Pierre-Gilles merged commit b71c50c into master Jun 10, 2024
11 checks passed
@Pierre-Gilles Pierre-Gilles deleted the google-cast-integration branch June 10, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant