Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gladys Plus integration #535

Merged
merged 13 commits into from
Sep 20, 2019
Merged

Improve Gladys Plus integration #535

merged 13 commits into from
Sep 20, 2019

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 13, 2019

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the documentation? (Documentation is based on comments in code)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #535 into master will decrease coverage by 0.12%.
The diff coverage is 69.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   91.39%   91.27%   -0.13%     
==========================================
  Files         342      345       +3     
  Lines        3882     3941      +59     
==========================================
+ Hits         3548     3597      +49     
- Misses        334      344      +10
Flag Coverage Δ
#server 91.27% <69.84%> (-0.13%) ⬇️
Impacted Files Coverage Δ
server/utils/constants.js 100% <ø> (ø) ⬆️
server/api/routes.js 97.95% <ø> (ø) ⬆️
server/lib/gateway/gateway.init.js 25.8% <0%> (-27.53%) ⬇️
server/api/controllers/gateway.controller.js 60% <100%> (+3.47%) ⬆️
server/lib/variable/index.js 100% <100%> (ø) ⬆️
server/lib/gateway/index.js 100% <100%> (ø) ⬆️
server/lib/variable/variable.destroy.js 100% <100%> (ø)
server/lib/gateway/gateway.loginTwoFactor.js 100% <100%> (ø) ⬆️
server/api/controllers/variable.controller.js 83.33% <100%> (+54.76%) ⬆️
server/lib/gateway/gateway.handleNewMessage.js 86.36% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dddd3...2f65a49. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 89a87d8 into master Sep 20, 2019
@Pierre-Gilles Pierre-Gilles deleted the improve-gladys-plus branch September 20, 2019 09:30
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
* Add variable.destroy function

* Add gateway.disconnect, forwardWebsockets and fix save user keys

* Add disconnect gateway button in front

* Run prettier

* Fix prettier

* Make websocket work with Gateway

* Fix tests

* Improve login flow & error handling

* At init, gateway check when last backup occurred

* Run prettier

* Add new route to get system variable by name

* Add view in UI to get/save backup key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant