Sonoff: improve device compliance

[atrovato]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
  - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Complete the device compatibility.
Remove manual creation.
Rename to Tasmota.

[atrovato]

Please @Pierre-Gilles don't forgot this PR, it a great refactor :)

[Pierre-Gilles]

@atrovato Don't worry, but the PR is really huge so it'll take a lot of time to review it.

For now all my time is dedicated to the scene feature, hope you'll understand! 😄

[atrovato]

I understand, please don't forget it :)

[Pierre-Gilles]

Hi ! I'm reviewing your PR and wanted to see the code coverage, I don't understand why the coverage is never reported on this PR specifically (works with other PR...)

I think it's because tests are passing on your CircleCI, not Gladys Assistant CircleCI ! Any idea ?

[atrovato]

It don't work all the time, on other PR too.
I try a rebase too force it.

[Pierre-Gilles]

Hi !

First, thanks for this really great PR ! 🙂

There is lots of work here, and quality work, no doubt =)

I noted a few feedbacks, most of them are just question, no change required.

There is just 2-3 comments with minor changes asked, but otherwise the rest of the code is perfect !

I'm looking forward to your answers to integrate this into Gladys !

[atrovato]

I have following URL on push coverage step:
https://codecov.io/github/********/Gladys/commit/a040e91670c8c62d985f8718e1ca0089575db03f

But ****** should be GladysAssistant or atrovato.

[Pierre-Gilles]

I have following URL on push coverage step:
https://codecov.io/github/********/Gladys/commit/a040e91670c8c62d985f8718e1ca0089575db03f

But ****** should be GladysAssistant or atrovato.

When I think about it I'm not sure this can work... Does codecov allow a forked repo to push data on my Codecov account ? I think it would be a security issue and I don't know if they allow that

No worries, I can push your branch on Gladys main repo before merging to have a full build in any case.

[Pierre-Gilles]

In fact, it works on other PR from fork!

Example:

https://codecov.io/gh/GladysAssistant/Gladys/pull/675

Maybe you are doing something differently? Did it work in the past for others PR you did?

[atrovato]

Ok, for test coverage, I unfollow my own GitHub repository, URL looks good for now.

[codecov]

Codecov Report

Merging #627 into master will increase coverage by 0.16%.
The diff coverage is 98.09%.

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   91.88%   92.05%   +0.16%     
==========================================
  Files         393      410      +17     
  Lines        4967     5134     +167     
==========================================
+ Hits         4564     4726     +162     
- Misses        403      408       +5

Flag	Coverage Δ
#server	92.05% <98.09%> (+0.16%)	⬆️

Impacted Files	Coverage Δ
server/services/tasmota/lib/disconnect.js	100% <ø> (ø)
server/utils/constants.js	100% <ø> (ø)	⬆️
server/services/tasmota/lib/connect.js	100% <ø> (ø)
server/services/tasmota/index.js	100% <100%> (ø)
server/services/tasmota/lib/notifyNewDevice.js	100% <100%> (ø)
.../services/tasmota/lib/features/colorTemperature.js	100% <100%> (ø)
server/services/index.js	100% <100%> (ø)	⬆️
...rver/services/tasmota/lib/features/energy.power.js	100% <100%> (ø)
server/services/tasmota/lib/features/power.js	100% <100%> (ø)
server/services/tasmota/lib/mqtt/status.js	100% <100%> (ø)
... and 47 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65624b6...32ff778. Read the comment docs.