Improve english localization-closes #674 #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 419 419
Lines 5427 5427
=======================================
Hits 5014 5014
Misses 413 413 Continue to review full report at Codecov.
|
|
Thanks for your PR 🙌 Is it ready for review/merge? |
|
Yes it is! |
|
Many thanks for this PR, just merged it 🙏 |
|
@all-contributors please add @Scott-Fischer for translation |
|
I've put up a pull request to add @Scott-Fischer! 🎉 |
NickDub-old
pushed a commit
to NickDub/Gladys
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)npm run compare-translationson front)front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Simple improvements to english translations as discussed in issue #674