Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[philips-hue] - Add devices #909

Merged
merged 8 commits into from Oct 30, 2020
Merged

[philips-hue] - Add devices #909

merged 8 commits into from Oct 30, 2020

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Oct 22, 2020 •
edited

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Adding devices to philips hue service

@VonOx VonOx marked this pull request as ready for review October 23, 2020 10:07
@VonOx
Copy link
Contributor Author

VonOx commented Oct 23, 2020

@Pierre-Gilles I'm sorry but i don't know why codecov is not working on my PR

@atrovato
Copy link
Contributor

If you "follow" your own Gladys git repo on circleci, codecov fails to sync with master repo.

@VonOx
Copy link
Contributor Author

VonOx commented Oct 23, 2020

What does that mean? I need to configure something?

@atrovato
Copy link
Contributor

On my side, I follow / unfollow according to my needs... there is a point to investiguate here...
No solution for now.

@VonOx
Copy link
Contributor Author

VonOx commented Oct 24, 2020

OK , https://codecov.io/gh/VonOx/Gladys/pulls nothing in PR , but ok on commits https://codecov.io/gh/VonOx/Gladys/commits

@VonOx
Copy link
Contributor Author

VonOx commented Oct 25, 2020

@atrovato I unfollow my own repo on circle for now. ( only need for ci testing )

https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited

Codecov Report

Merging #909 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         461      461           
  Lines        6147     6147           
=======================================
  Hits         5759     5759           
  Misses        388      388
Impacted Files Coverage Δ
.../services/philips-hue/lib/light/light.getLights.js 97.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167c0e5...58d7261. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 119e35b into GladysAssistant:master Oct 30, 2020
@Pierre-Gilles
Copy link
Contributor

Thanks for your PR !

R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
@VonOx @Pierre-Gilles
Handle Philips Hue LWV001, LTG002, LCT012 and LTA001 (GladysAssistant…
c1d2992 
…#909)

* Add LWV001

* Add LTG002

* Add LCT012

* Add LTA001

Co-authored-by: VonOx <vonox@VKUL-18KCQQ2.4cad-solutions.local>
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Gilles Pierre-Gilles Awaiting requested review from Pierre-Gilles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VonOx @atrovato @Pierre-Gilles