Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for #3 #4

Merged
merged 2 commits into from Aug 28, 2019
Merged

Documentation for #3 #4

merged 2 commits into from Aug 28, 2019

Conversation

ajmeese7
Copy link
Contributor

Added the new options to the table. You should probably also make a new release so people can download the minified version easily and you should update the file size in the README to reflect the changes.

Thanks for implementing these features! If you don't mind, I'm going to make another few issues with feature requests since soon I won't have access to a computer for a few months because I'm leaving for the Army. There's no rush to implement them, I just want to give you some ideas of how people use the library and what might attract more users. I know I'm liking it a lot more than the alternatives, and hopefully others will see what I do soon as the feature set grows. Cheers!

@Glagan
Copy link
Owner

Glagan commented Aug 28, 2019

I was waiting for you feedback on the implementation but I guess it's alright :)
Don't hesitate to make more issues I would gladly implement what you need ;)

@Glagan Glagan merged commit dfeefbd into Glagan:master Aug 28, 2019
@ajmeese7
Copy link
Contributor Author

I tried removeAllOnDisplay and it works perfectly. Thanks again! I'll be making a few more issues within the next couple days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants