Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving gitlab to github #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

KoreySoich
Copy link

Added testing to Java Games

@Glank
Copy link
Owner

Glank commented May 17, 2019

Thanks for the contribution!

I haven't pulled and tested this, but I imagine that adding these tests breaks the make files, so they would need to be excluded. Can you please also include documentation on how to run the tests?

@ruanwenjun
Copy link

@Glank The test class need to be placed in an other package, and use some tools such as maven to manage your project. If you do this, you can run the tests before each make files.

Copy link

@jdevfullstack jdevfullstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am reviewing this, the pull request is too broad to get the idea. Please separate this into several pull requests with respective focus or idea. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants