Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: case sensitivity in create table #2141

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: case sensitivity in create table #2141

merged 2 commits into from
Nov 21, 2023

Conversation

universalmind303
Copy link
Contributor

closes #2034

Turns out there was some implicit casting with Into<Column> + DfField::name that was casting it to lowercase. Using DfField::unqualified_column instead preserves the original field name.

@universalmind303 universalmind303 merged commit b88562b into main Nov 21, 2023
10 checks passed
@universalmind303 universalmind303 deleted the universalmind303/case-sensitive-tbl branch November 21, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychoish tychoish tychoish approved these changes

@scsmithr scsmithr scsmithr approved these changes

@vrongmeal vrongmeal Awaiting requested review from vrongmeal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to create table from table with case sensitive columns
3 participants
@universalmind303 @tychoish @scsmithr