Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename CREATE CREDENTIALS to CREATE CREDENTIAL #2180

Merged
merged 5 commits into from Nov 30, 2023
Merged

chore: rename CREATE CREDENTIALS to CREATE CREDENTIAL #2180

merged 5 commits into from Nov 30, 2023

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Nov 29, 2023

This PR adds CREATE CRDENTIAL as an SQL command and notifies the user of the deprecation of CREATE CREDENTIALS.

Closes: #2133

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@universalmind303
Copy link
Contributor

@Lilit0x can you add a slt for this as well? You can take a look at testdata/sqllogictests/credentials.slt for other examples.

@universalmind303 universalmind303 enabled auto-merge (squash) November 30, 2023 16:26
@universalmind303
Copy link
Contributor

thanks for the contribution @Lilit0x.

@tychoish tychoish merged commit 101f4c1 into GlareDB:main Nov 30, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: rename CREATE CREDENTIALS to CREATE CREDENTIAL
4 participants
@Lilit0x @CLAassistant @universalmind303 @tychoish