chore: Fix error message for invalid copy-to #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
vrongmeal
changed the title
tychoish
reviewed
Dec 6, 2023
| @@ -52,6 +52,11 @@ pub enum PlanError { | |||
| #[error("Invalid alter statement: {msg}")] | |||
| InvalidAlterStatement { msg: &'static str }, | |||
|
|
|||
| #[error("Invalid copy to statement: {source}")] | |||
| InvalidCopyToStatement { | |||
| source: Box<dyn std::error::Error + Send + Sync>, | |||
There was a problem hiding this comment.
ValidationError::CredentialsNotSupportedByDatasource
this error is always going to a Validation error, seems like we don't need the generic here?
There was a problem hiding this comment.
No, not really. Right now it is. But this is a flexible error to mark any invalid copy to statement. Something like InvalidCopyToStatement(ValidationError) implies that you can only have an invalid copy to statement due to a validation of options issue.
tychoish
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple update to error message.