feat: high level integration testing framework #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scsmithr
approved these changes
Dec 17, 2023
Comment on lines
+48
to
+49
| conn.autocommit = True | ||
| yield conn |
There was a problem hiding this comment.
We should open an issue on the autocommit thing since it's unexpected that it wouldn't work without setting it to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is (obviously) a very high level pytest harness for running
process and system integration tests, and the CI and developer
experience (just) integration. There's nothing special about this
pytest development, and I expect that it can grow with us as needs
evolve.
There are a class of tests that are difficult to run in the current
testing enviornments that this harness should make easy and
trivial. Such as:
cases that run a glaredb binary.
cases that involve the orchestration of multiple glaredb binaries.
operations that require introspection or manipulation of the
filesystem.
This shouldn't replace any of the existing tests:
use rust unittests for as much of the internals as possible.
anything that involves the python bindings should be written (also
using pytest) in
bindings/python/tests). This package shouldnever depend on the python bindings for build efficency reasons.
anything case that can be entirely expressed in SQL should be
written as a
sqllogictest(SLT).anything that requires the test of a specific service level
dependency (as in for data-sources) should run in the SLT
integration tests.