fix: Don't parse version-hint as a number for iceberg tables #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the first line of the `version-hint.text` and take it as it is to generate the metadata file name. Omit parsing it as a number since there are cases when it doesn't fit in an `i32` type. Instead of parsing it as an `i64` or `i128` we should simply skip it since such a version number seems like a bug and can happen again but shouldn't stop us from reading the table. Fixes #2277 Signed-off-by: Vaibhav <vrongmeal@gmail.com>
universalmind303
approved these changes
Dec 19, 2023
scsmithr
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the first line of the
version-hint.textand take it as it is to generate the metadata file name. Omit parsing it as a number since there are cases when it doesn't fit in ani32type. Instead of parsing it as ani64ori128we should simply skip it since such a version number seems like a bug and can happen again but shouldn't stop us from reading the table.Fixes #2277