Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: external table for cassandra #2361

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

universalmind303
Copy link
Contributor

closes #2345

Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure looks good, just want to change "connection_string" to "host"

crates/protogen/proto/metastore/options.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@universalmind303 universalmind303 merged commit 0b4b1fc into main Jan 8, 2024
13 checks passed
@universalmind303 universalmind303 deleted the universalmind303/cassandra-external-table branch January 8, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cassandra): EXTERNAL TABLE support for cassandra
4 participants