chore: Remove openssh from slt crate cargo.toml #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was causing build failures on windows. Didn't seem to be used anyways. Note that we conditionally use openssh in the datasources crate to get around this: ``` [target.'cfg(any(target_os = "linux", target_os = "macos"))'.dependencies] openssh = "0.10.2" ```
greyscaled
approved these changes
Jan 16, 2024
universalmind303
approved these changes
Jan 16, 2024
tychoish
approved these changes
Jan 16, 2024
It's mac and linux. It's for ssh tunnels for postgres and mysql. The windows implementation just returns an error saying unsupported on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was causing build failures on windows. Didn't seem to be used anyways.
Note that we conditionally use openssh in the datasources crate to get around this: