-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skip sqlserver+flight combination. #2526
Conversation
Co-authored-by: universalmind303 <cory.grinstead@gmail.com>
Not nothing. This is almost best case (good caches,) there were some scheduling delays, but we're mostly hitting the "compile+bindings" DAG limitation (which means there's another 4ish minutes of wall clock time that we could get. The runner is one of the small ones so this is budget neutral, but this will push build times from 10-15 minutes into 5-10 minutes. |
I think you tagged a wrong issue/PR Why this change though? Is it that Flight SQL is still in development so we can afford to skip some checks for now that take very long? |
It takes 4 or 5 minutes (there are a lot of CI PRs up at the moment, so the logic is a bit distributed,) to run the SQL server tests (which we were doing twice, for each protocol). Particularly since flightsql isn't deployed or used at the moment, this feels like a lot of time to be spent on tests like these. While I think it's important to run a lot of queries against different protocols and with different clients, I don't know that the matrix of combinations of protocols and data sources is going to give us a lot of signal (it might find things accidentally, but that doesn't feel like it'd be worth the wait time and we can have a stronger test strategy. |
Did a bit of buddy-system investigation with @scsmithr:
|
This (on top of #2518) should get wall clock time to about 10 minutes for an entire PR run, at the same cost.
It's likely redundant to the other suite. We could also switch datasource integration to just postgres as there's less postgres protocol coverage.