Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use microsecond precision for postgres datasource #2530

Merged
merged 6 commits into from
Jan 31, 2024
Merged

fix: Use microsecond precision for postgres datasource #2530

merged 6 commits into from
Jan 31, 2024

Conversation

vrongmeal
Copy link
Contributor 

> select * from read_postgres('postgresql://glaredb:password@0.0.0.0:5433/glaredb_test', 'public', 'abc');
┌─────────────────────┐
│ a                   │
│ ──                  │
│ Timestamp<µs, UTC>  │
╞═════════════════════╡
│ 0001-01-01T00:00:00 │
└─────────────────────┘

Fixes: #2438

@vrongmeal
fix: Use actual precision for clickhouse data types
7e6034e 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
formatting fix
dde3f8a
@vrongmeal
fix: Use microsecond precision for postgres datasource
7739fec 
```
> select * from read_postgres('postgresql://glaredb:password@0.0.0.0:5433/glaredb_test', 'public', 'abc');
┌─────────────────────┐
│ a                   │
│ ──                  │
│ Timestamp<µs, UTC>  │
╞═════════════════════╡
│ 0001-01-01T00:00:00 │
└─────────────────────┘
```

Fixes: #2438

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
fix obj store dt test
474aa27
@vrongmeal
Merge branch 'vrongmeal/more-time-precision' into vrongmeal/more-time…
bf9e824 
…-precision-pg
@vrongmeal vrongmeal marked this pull request as ready for review January 30, 2024 14:49
Base automatically changed from vrongmeal/more-time-precision to main January 31, 2024 07:21
@vrongmeal vrongmeal enabled auto-merge (squash) January 31, 2024 07:36
@vrongmeal vrongmeal merged commit 2038cdf into main Jan 31, 2024
22 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/more-time-precision-pg branch January 31, 2024 07:51
tychoish pushed a commit that referenced this pull request Feb 1, 2024
@vrongmeal @tychoish
fix: Use microsecond precision for postgres datasource (#2530)
075aaeb 
```
> select * from read_postgres('postgresql://glaredb:password@0.0.0.0:5433/glaredb_test', 'public', 'abc');
┌─────────────────────┐
│ a                   │
│ ──                  │
│ Timestamp<µs, UTC>  │
╞═════════════════════╡
│ 0001-01-01T00:00:00 │
└─────────────────────┘
```

Fixes: #2438

---------

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychoish tychoish tychoish approved these changes

@scsmithr scsmithr scsmithr approved these changes

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vrongmeal @tychoish @scsmithr