Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SQLite data source #2568

Merged
merged 24 commits into from
Feb 20, 2024
Merged

feat: SQLite data source #2568

merged 24 commits into from
Feb 20, 2024

Conversation

vrongmeal
Copy link
Contributor

@vrongmeal vrongmeal commented Feb 2, 2024 •
edited

TODO:

  • CREATE EXTERNAL TABLE
  • CREATE EXTERNAL DATABASE
  • Virtual listing
  • Tests
    • Fix filter pushdown for Sqlite
  • Support dates/times/timestamps

Followups:

@tychoish tychoish changed the title feat: Initial Sqlite support feat: SQLite data source, initial implementation Feb 2, 2024
tychoish
tychoish reviewed Feb 2, 2024
View reviewed changes
crates/datasources/src/sqlite/async_sqlite.rs Outdated Show resolved Hide resolved
crates/datasources/src/sqlite/convert.rs Outdated Show resolved Hide resolved
crates/datasources/src/sqlite/mod.rs Outdated Show resolved Hide resolved
crates/sqlbuiltins/src/functions/table/sqlite.rs Outdated Show resolved Hide resolved
@vrongmeal
feat: Initial Sqlite support
f48746f 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
use async-sqlite instead of self impl
7f572a7 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
external database
7cfb645 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
ext table and virt list
c48ba69 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
support dates and times...
09aa412 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
Merge remote-tracking branch 'origin/main' into vrongmeal/sqlite
56d70d4
@vrongmeal
fix filter pushdown
9bcfb32
@vrongmeal
fix schema interpretation (basically don't do it)
3a000b7 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
add sqlite data setup
6424bfc 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
we have ci
bf1392e 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
fix clippy
4f1abd5 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
Merge remote-tracking branch 'origin/main' into vrongmeal/sqlite
79e0374
@vrongmeal vrongmeal mentioned this pull request Feb 14, 2024
Closed
@vrongmeal vrongmeal changed the title feat: SQLite data source, initial implementation feat: SQLite data source Feb 14, 2024
tychoish
tychoish previously approved these changes Feb 14, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
scripts/create-test-sqlite-db.sh Outdated Show resolved Hide resolved
crates/datasources/src/sqlite/wrapper.rs Outdated Show resolved Hide resolved
crates/datasources/src/sqlite/wrapper.rs Outdated Show resolved Hide resolved
crates/datasources/src/sqlite/wrapper.rs Show resolved Hide resolved
crates/datasources/src/sqlite/wrapper.rs Show resolved Hide resolved
tychoish
tychoish reviewed Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, didn't mean to hit approve yet. it is good though.

@vrongmeal
without join handle
054d6f5 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
easy ci
adbb254 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
Merge remote-tracking branch 'origin/main' into vrongmeal/sqlite
514b146
@vrongmeal
fix ci sqlite
82b8ff1 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
remove sqlite setup script
40d3120 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
cleaner hook setup
5c42a1f 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
tychoish
tychoish approved these changes Feb 20, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@vrongmeal
run sqlite setup only when requested
27ba52f 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
fix sqlite fmt
21f9a23 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
cleanup sqlite dataset
06b4b9b 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal vrongmeal merged commit 5051b59 into main Feb 20, 2024
25 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/sqlite branch February 20, 2024 17:17
@judahrand judahrand mentioned this pull request Mar 1, 2024
Merged
tychoish pushed a commit that referenced this pull request Mar 1, 2024
@judahrand
chore: add SQLite to list of supported Databases (#2717)
2d677a0 
(documentation only change, after #2568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychoish tychoish tychoish approved these changes

@universalmind303 universalmind303 Awaiting requested review from universalmind303

@scsmithr scsmithr Awaiting requested review from scsmithr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vrongmeal @tychoish @scsmithr