Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support inserts into mongodb #2605

Merged
merged 20 commits into from
Feb 9, 2024
Merged

feat: support inserts into mongodb #2605

merged 20 commits into from
Feb 9, 2024

Conversation

tychoish
Copy link
Collaborator

@tychoish tychoish commented Feb 6, 2024 •
edited

  • let CI pass once to make sure something hasn't gone awry
  • write tests

universalmind303
universalmind303 reviewed Feb 7, 2024
View reviewed changes
crates/datasources/src/mongodb/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/mongodb/mod.rs Outdated Show resolved Hide resolved
crates/datafusion_ext/src/stream.rs Outdated Show resolved Hide resolved
crates/datasources/src/bson/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/bson/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/bson/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/bson/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/bson/mod.rs Outdated Show resolved Hide resolved
@tychoish tychoish mentioned this pull request Feb 8, 2024
Merged
vrongmeal
vrongmeal approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, otherwise, looks great!

crates/datasources/src/mongodb/mod.rs Outdated Show resolved Hide resolved
crates/datasources/src/mongodb/insert.rs Outdated Show resolved Hide resolved
@tychoish tychoish enabled auto-merge (squash) February 9, 2024 20:12
@tychoish tychoish merged commit eb43f49 into main Feb 9, 2024
22 checks passed
@tychoish tychoish deleted the tycho/mdb-insert-support branch February 9, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrongmeal vrongmeal vrongmeal approved these changes

@scsmithr scsmithr Awaiting requested review from scsmithr

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tychoish @universalmind303 @vrongmeal