-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metastore): make builtin schemas readonly #2617
Conversation
The user_files schema is intended to be a well-known schema for accessing files uploaded in cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this but @scsmithr or @vrongmeal should give it the once over.
sounds good, added them as reviewers. I've also updated the code since your last review to remove the |
This adds a restriction in metastore for creating entries on builtin schemas, other than the default schema (`public`).
Summary
This adds a restriction in metastore for creating entries on builtin schemas, other than the default schema (
public
).Details
Initially, this added a builtin schema
glare_uploads
(#2614), but we later decided to remove it and instead use a table funcition.At the time,
glare_uploads
was chosen because prefixing internal schemas withglare_
reduces collision chance, and is what pg does.Read more on pg_
From https://www.postgresql.org/docs/current/ddl-schemas.html
Progress
glare_uploads
schema