Feat: Create External Table support for Excel #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychoish
requested changes
Feb 15, 2024
| @@ -275,7 +276,8 @@ impl<'a> ExternalDispatcher<'a> { | |||
| let tunnel = self.get_tunnel_opts(table.tunnel_id)?; | |||
|
|
|||
| match &table.options { | |||
| TableOptions::Internal(TableOptionsInternal { .. }) => unimplemented!(), // Purposely unimplemented. | |||
| TableOptions::Internal(TableOptionsInternal { .. }) | |||
| | TableOptions::Excel(TableOptionsExcel { .. }) => unimplemented!(), // Purposely unimplemented. | |||
There was a problem hiding this comment.
I would think that we'd be able to implement this, but let's make excel todo!() rather than unimplemented: we would like to do it eventually, I think.
tychoish
reviewed
Feb 16, 2024
| @@ -887,7 +887,8 @@ impl<'a> SessionPlanner<'a> { | |||
| let has_header = storage_options | |||
| .inner | |||
| .get("has_header") | |||
| .map(|val| val.parse::<bool>().unwrap_or_else(|| false))?; | |||
| .map(|val| val.parse::<bool>().unwrap_or(false)) | |||
There was a problem hiding this comment.
I just opened a different PR for the table function to have this default to true
There was a problem hiding this comment.
Sure, will change it here as well.
|
@tychoish Can this PR be merged now? |
tychoish
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature for #2644
Hello @tychoish
By taking this as reference, I added sheet_name as option in
TableOptionsExcel- This is different from Bson model.Please review, Thanks.