chore(ci): build images from 'main' #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are no longer getting updates to the `main` tag
greyscaled
commented
Feb 15, 2024
| @@ -588,7 +576,6 @@ jobs: | |||
| just slt-bin 'sqllogictests_snowflake/*' | |||
| just slt-bin --protocol=rpc 'sqllogictests_snowflake/*' | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
All changes before this point were just automagic lint/fmt 🤷🏻
scsmithr
approved these changes
Feb 15, 2024
tychoish
reviewed
Feb 15, 2024
| docker-push: | ||
| name: Build and Push Docker Image | ||
| if: github.event_name == 'push' && github.repository == 'GlareDB/glaredb' && github.ref == 'refs/heads/main' | ||
| runs-on: ubuntu-latest-8-cores |
There was a problem hiding this comment.
depending on if we decide to reuse the previous artifacts or not we can downside this.
There was a problem hiding this comment.
I'd be happy to accomplish both. The code as-is was just copy-pasta'd from the release variant, but since this runs on every push to main and is generally OK to take longer, I'm happy to downsize.
greyscaled
commented
Feb 15, 2024
Co-authored-by: Grey <grey@glaredb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are no longer getting updates to the
maintag