Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infer_func_for_file): remove dead code #2677

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Feb 21, 2024

Duplicated match arm (dead code) causing lint failure in CI (see: https://github.com/GlareDB/glaredb/actions/runs/7991177287/job/21822034352)

Duplicated match arm (dead code) causing lint failure
@hemanth94
Copy link
Contributor

@greyscaled Sorry for this mistake, I didn't check the duplicate match arm.

@tychoish tychoish merged commit 770f4e4 into main Feb 21, 2024
25 checks passed
@tychoish tychoish deleted the grey/infer-lint branch February 21, 2024 16:19
@greyscaled
Copy link
Contributor Author

greyscaled commented Feb 21, 2024

@greyscaled Sorry for this mistake, I didn't check the duplicate match arm.

Hey @hemanth94 , that's not your fault. This should be caught in CI and unfortunately it looks like clippy stalled out on a cache step and none of us as reviewers noticed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants