Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add postgres dbt model to dbt tests #2703

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Conversation

talagluck
Copy link
Contributor

@talagluck talagluck commented Feb 26, 2024

I know there are issues here, but sharing for early review:

  • Changes the expected test outcome for the view materialization in the existing dbt test from fail to pass
  • Adds a test confirming that dbt will work with an external postgres database. This uses the actual external demo postgres instance that we mention in our docs, so is probably brittle. Ideally, we would spin something up (Docker?) for the purpose of the test.
  • Overall, this could also probably use some refactoring, but I think that that will take some pytest magic which may make the tests less legible.

Copy link
Collaborator

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all seems good.

tests/tests/test_dbt.py Outdated Show resolved Hide resolved
tests/tests/test_dbt.py Outdated Show resolved Hide resolved
tests/tests/test_dbt.py Outdated Show resolved Hide resolved
@talagluck talagluck merged commit d49fbd1 into main Feb 28, 2024
25 checks passed
@talagluck talagluck deleted the tal/add_postgres_dbt branch February 28, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants