fix(rpc): set is_cloud_instance
remote session var
#2715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloud_upload
was working via pg proxy but not rpc (see #2714).I saw that we do this in the pg srv handler:
glaredb/crates/pgsrv/src/handler.rs
Line 261 in d49fbd1
and tried to find an equivalent spot in RPC code paths, though I'm not 100% on how to grok hybrid exec through the codebase.
I deployed this change to QA, and it works on Cloud QA with the CLI, and doesn't seem to unsafely set the cloud instance var: