fix: Iceberg for format v1 #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this commit simply adds `#[serde(default)]` for fields that are required in v1 (or sets a valid default). We do need more datasets to test this on. There's some deprecated stuff that might require more attention to support. Signed-off-by: Vaibhav <vrongmeal@gmail.com>
tychoish
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
I feel like we could write some random generators for iceberg data and (maybe there are some scripts/generators that we could take advantage of?) and get that hooked up to the pytests to generate some datasets on the fly.
I also sort of want to test this through other object-storage layers, mostly because my trust of the object_store crate is pretty low.
Having said that, I don't think either of these things should block merging, and this patch is pretty great.
tychoish
pushed a commit
that referenced
this pull request
Mar 5, 2024
Currently this commit simply adds `#[serde(default)]` for fields that are required in v1 (or sets a valid default). We do need more datasets to test this on. There's some deprecated stuff that might require more attention to support. Signed-off-by: Vaibhav <vrongmeal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this commit simply adds
#[serde(default)]for fields that are required in v1 (or sets a valid default).We do need more datasets to test this on. There's some deprecated stuff that might require more attention to support.