Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add explicit schema support for json streaming #2766

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chore: add explicit schema support for json streaming #2766

merged 2 commits into from
Mar 12, 2024

Conversation

tychoish
Copy link
Collaborator

@tychoish tychoish commented Mar 8, 2024

This is the same implementation as in the BSON, need to have an
external table connection to wire this up directly.

@tychoish tychoish requested a review from vrongmeal March 11, 2024 13:51
vrongmeal
vrongmeal approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@tychoish tychoish enabled auto-merge (squash) March 12, 2024 16:20
@tychoish tychoish merged commit b22313f into main Mar 12, 2024
25 checks passed
@tychoish tychoish deleted the tycho/json-schema-pushdown branch March 12, 2024 16:34
tychoish added a commit that referenced this pull request Mar 13, 2024
@tychoish
chore: add explicit schema support for json streaming (#2766)
708cfd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrongmeal vrongmeal vrongmeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tychoish @vrongmeal