Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some issues with the UART applet's auto-baud detection. #260

Closed
wants to merge 2 commits into from

Commits on Jan 7, 2021

  1. applet.interface.uart: fix auto-baud on single frames

    When receiving a single frame that is at a faster baudrate than is
    currently configured, it is possible that you won't see a frame or
    parity error, especially if no parity is selected. This is because the
    line idles high, which looks identical to a stop bit.
    
    Even if you have parity enabled, there is a non-zero chance you'll see
    the high line state, and consider it to be a "valid" parity bit, when in
    fact it is the idle state.
    
    When receiving a stream of frames in quick succession, there is a higher
    probability that you will look for a stop bit in the next frame, and
    will thus see a frame error (or parity error).
    attie-argentum committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    15f0d1d View commit details
    Browse the repository at this point in the history
  2. applet.interface.uart: only report baud updates when outside a +/- 5%…

    … window
    
    Because we are now updating the bit time whenever it changes, it is
    possible to get a lot of "switched to __ baud" messages, even if the
    change is minor and well within tolerance.
    
    This patch will only report baudrate changes when they exceed a +/- 5%
    window vs the previously reported baudrate.
    attie-argentum committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    f6ebade View commit details
    Browse the repository at this point in the history