Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using "prettier" for JS and JSX #1497

Closed
ghost opened this issue Jan 31, 2017 · 10 comments · Fixed by #2047
Closed

Consider using "prettier" for JS and JSX #1497

ghost opened this issue Jan 31, 2017 · 10 comments · Fixed by #2047
Assignees

Comments

@ghost
Copy link

ghost commented Jan 31, 2017

https://github.com/jlongster/prettier

@guiguan
Copy link
Contributor

guiguan commented Apr 10, 2017

Strongly recommend prettier, which is used by Facebook as well

@Glavin001
Copy link
Owner

Pull Requests welcome! 👍

@york-xtrem
Copy link

It would be brutal!
I change it VSCode to Atom only for this Atom-beautify if it already includes Prettier It would be great !!

@Glavin001 Glavin001 changed the title Consider using "prettier" for JS ans JSX Consider using "prettier" for JS and JSX Aug 12, 2017
@Glavin001
Copy link
Owner

Atom-Beautify will be coming to VSCode! See https://github.com/Unibeautify/vscode
Once again, Pull Requests welcome to add Prettier support. If not, maybe in the upcoming months I will have time to add it myself 😄 .

@york-xtrem
Copy link

Thank you Glavin!
I'm a newbie in creating extensions, I am now with snippets for Nunjucks in VSCode.
I'll try to see how to support Prettier.

@utilityboy
Copy link

@Glavin001 / @york-xtrem I can give this a shot if no work has started. @Glavin001, should I just fork off master at this point, or should I work this up elsewhere?

@york-xtrem
Copy link

@utilityboy I finally adopted the environment https://www.jetbrains.com. It has everything I need and everything works well at first with great support! Neither Atom, nor visual studio code, nor Sublime, nor anything ...

@prettydiff
Copy link
Collaborator

@utilityboy You should check out the future of Atom Beautify at https://github.com/Unibeautify/

The goal is to get beautifiers in as many editors as possible. We could use a bunch of help as there is a lot of work let to do. Here is an over simplification of necessary tasks:

  1. Create a universal parsing framework that can parse all the languages and allow seamless interchange between various languages/formats.
  2. Adapt existing beautifiers to use the Unibeautify parse-framework and output beautified code.
  3. Create standard interfaces between various code editors and the Unibeautify application that exposes a standard set of options and outputs beautified code.

At this time the maintains of JS Beautify and Pretty Diff are collaborators on Unibeautify working hard to achieve this vision. The guys behind Prettier have expressed great interest in this, as well, but there is still a lot of work to do. If you want Prettier to be available to many various code editors I would suggest enhancing Prettier to support the Unibeautify parse-framework and working through their unit tests. Currently Prettier uses Babel and Flex for their parsers.

@jonyeezs
Copy link

just to add, typescript users recommend prettier too

@Glavin001
Copy link
Owner

Prettier will be included in Unibeautify! https://github.com/Unibeautify/beautifier-prettier 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants