Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify Editor command should come first in command palette list #240

Closed
framerate opened this issue Mar 17, 2015 · 7 comments
Closed

Beautify Editor command should come first in command palette list #240

framerate opened this issue Mar 17, 2015 · 7 comments
Assignees
Milestone

Comments

@framerate
Copy link

Love this plugin. My workflow is usually:

command + shift + p ---> type "beaut" ---> hit enter.

The new version added a "debug" command that is at the top of the auto complete list and it causes me to hit it all the time.

I don't know the origin of the debug command, but would it be possible to at least order it at the bottom so it doesn't accidentally fire?

@Glavin001
Copy link
Owner

I don't know the origin of the debug command,

See #237 and #236.

My workflow is usually:
command + shift + p ---> type "beaut" ---> hit enter.

I recommend using a keyboard shortcut for beautify:beautify-editor.

The new version added a "debug" command that is at the top of the auto complete list and it causes me to hit it all the time.
...
would it be possible to at least order it at the bottom so it doesn't accidentally fire?

I am not entirely sure why it would appear first (b in beautify editor comes before d in debug last time I checked), however I would also like to see beautify editor appear first in that list, so if you figure out why it is ordering that way and how to change it, please let me know.

@Glavin001 Glavin001 changed the title Suggestion: Remove Debug Command (or Rename) Beautify Editor command should come first in command palette list Mar 17, 2015
@ponychicken
Copy link

That annoys me a lot. I don't use beautify enough to remember the keyboard shortcut and now I frequently hit this debug thing. (I still like the plugin a lot, but this feels like a regression in usability to me)

@Glavin001
Copy link
Owner

That annoys me a lot.

Me, too.

now I frequently hit this debug thing ...
... this feels like a regression in usability to me

The addition of the Debug command is an excellent feature with many advantages, given the large quantity of Issues created and the severe lack of quality in debugging information provided by users to allow me to resolve them.

However, I do see your use case, and while it is a little "bug", and not even Atom Beautify's fault -- it is caused by how Atom orders the commands, see atom/command-palette#2 (comment) and atom/command-palette#28 and https://github.com/atom/fuzzaldrin -- I will attempt to find a solution for you, since you are resistant to the common practice of using keyboard shortcuts.

@Glavin001 Glavin001 added this to the v1.0.0 milestone Mar 20, 2015
@Glavin001 Glavin001 self-assigned this Mar 20, 2015
@Glavin001
Copy link
Owner

Published fix to v0.22.4

Please check and let me know it works for you.

@framerate
Copy link
Author

Looks great! I had to restart atom to see it, so make sure you do that if you’re verifying!

Thanks so much!

@Glavin001
Copy link
Owner

I had to restart atom to see it

Yeah, updating packages in Atom rarely works well. I make it a habit of always restarting Atom after any package changes.

Thanks so much!

You're welcome! Let me know if there's anything else.

@ponychicken
Copy link

Fantastic, that did the trick for me.

On Fri, Mar 20, 2015 at 5:34 PM, Glavin Wiechert notifications@github.com
wrote:

Closed #240 via e67425f.

Reply to this email directly or view it on GitHub:
#240 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants