Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not passing 'preserve_newlines' args through to Prettydiff for LESS/SCSS formatting #245

Closed
sebastiankade opened this issue Mar 19, 2015 · 4 comments
Assignees
Milestone

Comments

@sebastiankade
Copy link

When specifying the preserve_newlines in .jsbeautifyrc they do not get passed through to prettydiff, see:
https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/css-prettydiff-beautify.coffee#L4-L10

Originally raised here:
#211 (comment)

@Glavin001
Copy link
Owner

Looks like preserve_newlines is not even supported on CSS (yet): beautifier/js-beautify#537

I'm working on Prettydiff support now.

@Glavin001
Copy link
Owner

The only property I see is preserve ( see 31 in http://prettydiff.com/documentation.php#function_properties ). Is that the preserve_newlines you are looking for?

Retain empty lines in either JavaScript or CSS like languages. Consecutive empty lines will be converted to a single empty line.

@Glavin001
Copy link
Owner

Published to v0.22.5

Atom Beautify uses a boolean (true or false) value for preserve_newlines option and will translate to all in Prettydiff. Support is only for LESS/SCSS/SASS (Prettydiff supported languages).

Thank you for your patients.

@Glavin001 Glavin001 self-assigned this Mar 20, 2015
@Glavin001 Glavin001 added this to the v1.0.0 milestone Mar 20, 2015
@sebastiankade
Copy link
Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants