New options added to Pretty Diff

[prettydiff]

Just a quick FYI. Over the past month or so a couple new options have been added to the Pretty Diff tool:

• commline - XSLT extensions for beautification prettydiff/prettydiff#139
• noleadzero - Add CSS option to remove leading 0 before a decimal prettydiff/prettydiff#146
• spaceclose - XSLT extensions for beautification prettydiff/prettydiff#139
• tagsort - Xml comparison ignoring child element order prettydiff/prettydiff#89
• endcomma - New JS option to inject trialing commas in object literals prettydiff/prettydiff#160
• methodchain - break chain method prettydiff/prettydiff#161
• nocaseident - Indent case and default blocks of switch/case sections in JavaScript prettydiff/prettydiff#179
• crlf - Line terminator option prettydiff/prettydiff#186
• selectorlist - Create new option, CSS selector list on one line prettydiff/prettydiff#189
• ternaryline - Optionally leave ternary statements on a single line prettydiff/prettydiff#226
• neverflatten - Create new option to prevent flattened objects prettydiff/prettydiff#201

[Glavin001]

Awesome, thanks @prettydiff !

For anyone interested in making a Pull Request and want to know how:

• Applicable Pretty Diff beautifier code: https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/prettydiff.coffee#L7-L29
• Make sure the allowed languages ( from https://github.com/Glavin001/atom-beautify/tree/master/src/languages ) have those options available.

Try to keep the naming standardized. For example, Atom Beautify should have one way to name an option and it should use beautifier mapps to convert naming of options to JS Beautify and Pretty Diff conventions.

[prettydiff]

Just added a new option endcomma in resolution to #534

I am not sure if this will be helpful for you, but I just added support for a .prettydiffrc file. The way it works is that the node-local.js file will first look for this file in the directory currently active in the command prompt and if not available then checks for this file in the application's directory. The file is first checked for JSON format and if not JSON format checks to see if the file is a JavaScript application. The file is not evaluated until after options supplied from the command line are evaluated. The JavaScript application format is available to allow optional complexity so that users can define options conditional upon options supplied from the command line, such as defining options per language, mode, or a combination of options. Here is an example of the file in JavaScript format: http://prettydiff.com/.prettydiffrc

[Glavin001]

I am not sure if this will be helpful for you, but I just added support for a .prettydiffrc file.

I think this may be very helpful for users who want to use new Pretty Diff features that Atom Beautify has not yet added support for. Thanks!

[Glavin001]

This comment is designed to address #543 and help @abea potentially submit a Pull Request. With some additional thought you could easily implement all of the other options, too.

---

Here's a TODO list that can guide you to create this Pull Request:

• Add the option to the css language
  • See https://github.com/Glavin001/atom-beautify/blob/master/src/languages/css.coffee#L30
  • Note that the sass language will fallback and apply options set to css namespace: https://github.com/Glavin001/atom-beautify/blob/master/src/languages/sass.coffee#L5
  • This means that putting the option on the css language will mean both css, sass, and others that fallback to css will be able to use it too!
• Allow the option to be used by the Pretty Diff beautifier within Atom Beautify
  • See https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/prettydiff.coffee#L8
  • Add the key for the option and it will now be available internally to the beautifier when beautify is called at https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/prettydiff.coffee#L51
• Update the documentation
  • run coffee docs/ and commit these documentation changes, too

That's it! Let me know if you have any questions.

[Glavin001]

I just finished up some stuff for work and have a few minutes before I have to leave. I'll try to implement all of these right now 😃.

[Glavin001]

Published to v0.28.12:

• CSS option no_lead_zero
• JavaScript option end_with_comma

[prettydiff]

Awesome!

[joshholl]

added pull request for ternary line option #726

[astanciu]

@prettydiff

I just added support for a .prettydiffrc file.

Any docs that show where to put this file? you mention:

. The way it works is that the node-local.js file will first look for this file in the directory currently active in the command prompt and if not available then checks for this file in the application's directory.

...but this is confusing in the context of Atom. Unless it's only meant to work as a cli tool

[prettydiff]

@astanciu Just put everything in the .jsbeautifyrc file. Atom Beautify consolidates all options into that one file.

[astanciu]

I tried that, didn't work for some options. See:
#1191

[Glavin001]

@prettydiff : The current Pretty Diff beautifier within Atom-Beautify will only apply the options that are explicitly supported: https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/prettydiff.coffee#L10-L43
This is because the options differ from the language options.
Missing options need to be added.

[Glavin001]

For anyone waiting on options, I recommend that you submit a Pull Request yourself. It is very simple. For example: #1193
Thanks!