Improve PHP-CS-Fixer config file support #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a PHP-CS-Fixer setting to specify a custom config file. If no setting is provided, check first the working directory then the project root for `.php_cs` and `.php_cs.dist`. Update the example link to PHP-CS-Fixer source to accommodate the new code. Fix capitalization in the "Allow risky rules" description.
|
Looks good to me! |
|
Thank you for contributing! |
|
Published to v0.29.26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR adds a PHP-CS-Fixer setting to specify a custom config file. If no setting is provided, it checks first the working directory then the project root for
.php_csand.php_cs.distand uses whichever it finds first.I also updated the example link to PHP-CS-Fixer source in
add-languages-and-beautifiers.mdto account for the additions, and fixed the capitalization in the "Allow risky rules" setting description.Does this close any currently open issues?
#1524, part of #1537, possibly #915.
Any other comments?
This has only been tested on PHP-CS-Fixer version 2.3.1 on OS X, though it's unlikely to behave differently on PHP-CS-Fixer 1.x or Windows.
Checklist
Check all those that are applicable and complete.
masterbranchnpm run docsCHANGELOG.mdunder "Next" section