Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VHDL Support via Emacs #1980

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Added VHDL Support via Emacs #1980

merged 1 commit into from
Mar 2, 2018

Conversation

g0t00
Copy link

@g0t00 g0t00 commented Dec 7, 2017

What does this implement/fix? Explain your changes.

Added VHDL Support via Emacs. (Analog to Fortran Support)

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch
  • Regenerate documentation with npm run docs
  • Add change details to CHANGELOG.md under "Next" section
  • Added examples for testing to examples/ directory
  • Travis CI passes (Mac support)
  • AppVeyor passes (Windows support)

@stale
Copy link

stale bot commented Feb 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 5, 2018
@g0t00
Copy link
Author

g0t00 commented Feb 5, 2018

This is still relevant. I really would like this to merge.

@stale stale bot removed the stale label Feb 5, 2018
@Glavin001 Glavin001 self-requested a review March 2, 2018 00:51
@Glavin001 Glavin001 self-assigned this Mar 2, 2018
]

if emacs_path
@deprecateOptionForExecutable("Emacs", "emacs_path", "Path")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This emacs_path option is no longer needed as use of Executables on line 12-20 replaces it.

@debug('vhdl-beautifier', options)
emacs = @exe("emacs")

emacs_path = options.emacs_path
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove emacs_path.

###
options:
# JavaScript
emacs_path:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This emacs_path option is no longer needed as use of Executables on line 12-20 replaces it.

@Glavin001
Copy link
Owner

Thank you for contributing!

@Glavin001 Glavin001 added this to the v0.32.0 milestone Mar 2, 2018
@Glavin001
Copy link
Owner

Published to v0.32.0

@Glavin001 Glavin001 mentioned this pull request Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants