Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker fix #2134

Merged
merged 5 commits into from
May 15, 2018
Merged

Docker fix #2134

merged 5 commits into from
May 15, 2018

Conversation

stevenzeck
Copy link
Contributor

What does this implement/fix? Explain your changes.

Fixes an issue with executables not running php-cs-fixer from phar files properly
...

Does this close any currently open issues?

Closes #2132
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch
  • Regenerate documentation with npm run docs
  • Add change details to CHANGELOG.md under "Next" section
  • Added examples for testing to examples/ directory
  • Travis CI passes (Mac support)
  • AppVeyor passes (Windows support)

@Glavin001 Glavin001 self-requested a review May 15, 2018 17:28
Glavin001
Glavin001 requested changes May 15, 2018
View reviewed changes
Copy link
Owner

@Glavin001 Glavin001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need CHANGELOG update.

@stevenzeck stevenzeck merged commit cfc7b86 into Glavin001:master May 15, 2018
@stevenzeck stevenzeck deleted the docker-fix branch May 15, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glavin001 Glavin001 Glavin001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error is not defined
2 participants
@stevenzeck @Glavin001