Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocamlformat formatter for OCaml. #2207

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

utkarshkukreti
Copy link
Contributor

@utkarshkukreti utkarshkukreti commented Aug 23, 2018

What does this implement/fix? Explain your changes.

Adds an alternative formatter for OCaml.

Does this close any currently open issues?

Nope.

Any other comments?

I followed the steps here except the 4th one -- I'm not sure how to add tests for this. https://github.com/Glavin001/atom-beautify/tree/master/examples/nested-jsbeautifyrc/ocaml already includes a test case for ocp-indent and I couldn't figure out to create one for ocamlformat.

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch
  • Regenerate documentation with npm run docs
  • Add change details to CHANGELOG.md under "Next" section
  • Added examples for testing to examples/ directory
  • Travis CI passes (Mac support)
  • AppVeyor passes (Windows support)

@stevenzeck stevenzeck merged commit 80280bb into Glavin001:master Sep 12, 2018
@stevenzeck
Copy link
Contributor

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants