Add Optional Path for Rubocop #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apparently the appveyor build is failing generating documentation, or so it seems. Is it safe to ignore? |
|
I will ignore the AppVeyor tests. Could you run "coffee docs/" to build the documentation with the new option and commit that change with this pull request? Looks about ready to merge. Thanks! |
|
done |
|
Awesome. Great work! Thank you so much for contributing! |
Glavin001
added a commit
that referenced
this pull request
Nov 23, 2015
Add Optional Path for Rubocop
|
my pleasure |
|
hi, can I ask you if you can push a new minor release? |
|
Published to v0.28.20 |
|
thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add option to specify the path for rubocop in the settings.
The relative beautifier now retrieve the path similarly to how the php-cs-fixer one does.
I tested it and is working correctly on my system.