Removed cross-spawn dependency #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might fix the "spawn cmd.exe ENOENT" issue on Windows.
|
By analyzing the blame information on this pull request, we identified @splodingsocks and @emanuelet to be potential reviewers |
|
Interestingly I solved another huge, tangential issue for me with cargo-build. |
|
Looks like only two tests are failing and I have confirmed both are unrelated. |
|
Published to v0.29.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes the
spawn cmd.exe ENOENTerror on Windows and makes it possible to run various tools again.Does this close any currently open issues?
Probably #396, #456, #456, #598, #768, and #932. Possibly more.
Any other comments?
This change fixed the support of
rustfmtfor me. I did not test it with any other tool like those in the linked issues above.Checklist
Check all those that are applicable and complete.
masterbranch