Discord.JS Module Usage #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up imports for these commands
Also some button objects to builders and other relevant changes
Glazelf
added
the
optimization
Closed
reusing builders is kinda weird
Maybe this should have been several commits but I'm tired - Rework how guild IDs are handled (see /send) - Rework a ton of commands - Give /ban and /send subcommands - Probably a lot more that I'm forgetting - Probably new bugs
Makes it more consistent since it happens later in the boot process
Also rework some variable usage
|
All tasks completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve usage of the Discord.JS package in a few key ways:
import Discord from "discord.js", specify which parts are needed.SlashCommandBuilderinstead of rawjson, this avoids repetition and should improve readability.ButtonBuilderproperly instead of passing objects..setDMPermission(false)instead of current check for DM channels.globalVars.