Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzyset 1.0.6 and above not working when webpacked #55

Open
fergiemcdowall opened this issue May 4, 2022 · 6 comments
Open

fuzzyset 1.0.6 and above not working when webpacked #55

fergiemcdowall opened this issue May 4, 2022 · 6 comments

Comments

@fergiemcdowall
Copy link

fergiemcdowall commented May 4, 2022

Hi and thanks for a great lib!

I have found that fuzzyset@1.0.6 and above works great in vanilla node apps, but seems to stop working when webpacked. 1.0.5 works for me in both scenarios.

@Glench
Copy link
Owner

Glench commented May 4, 2022

Can you please provide some steps to reproduce what you're seeing? And the latest version should be 1.0.7.

@fergiemcdowall
Copy link
Author

Applies to 1.0.6 and above (so also 1.0.7)

Fuzzyset is used in one of the search-index tests. In this testsearch-index creates a dictionary from a corpus and then feeds that dictionary into fuzzyset

To replicate the problem:

  1. Clone search-index
  2. npm install
  3. run npm run test-node and npm run test-browser (tests pass 🎉)
  4. In package.json update fuzzyset to 1.0.7 (or 1.0.6)
  5. rm -rf node_modules && npm install
  6. Run npm run test-node (tests pass 🎉)
  7. Run npm run test-browser (same tests fail on fuzzyset)

This is not a super big issue for me, and I know that slogging through somebody elses webpack config is pretty time consuming, so its cool to just treat this as an "incident report" and only follow up on it if other users report the same behaviour.

@Glench
Copy link
Owner

Glench commented May 4, 2022

Thanks for the report and replication steps!

To others viewing this thread, please comment here if you're also impacted by this issue.

@ArmelChesnais
Copy link

My team is impacted by this as well.

@Glench
Copy link
Owner

Glench commented Jun 16, 2022

Please consider posting some of your config in a way that reproduces the issue.

@nikodevv
Copy link

Ran into this issue on webpack ^5.74.0. I started writing out our config but we quite a complicated monorepo set up, and I don't think I'll have the time to write it all out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants