Use IDictionary.Contains instead of exceptions to get glimpse request id

[jeffora]

Don't use exceptions for control flow when it's not an 'exceptional' situation, and a perfectly good alternative exists. It's bad (tm). Or more to the point, it's friggen annoying when debugging (also slower etc).

[avanderhoorn]

@jeffora Sorry for the delay. We are going to be doing some work on this stuff tomorrow night and will bring this in then. Thanks for the patch!

[nikmd23]

how about this:

var guid = context.Items[GlimpseConstants.GlimpseRequestId] as Guid?;

        if (guid.HasValue)
            return guid.Value;

        Guid result;
        context.Items[GlimpseConstants.GlimpseRequestId] = result = Guid.NewGuid();
        return result;

[jeffora]

Yeh that would work. Forgot about the need to store the new GUID when answering yesterday. Sorry took so long to comment, I didn't have access to a computer yesterday and wasn't sure on whether the context dictionary would throw a KeyNotFoundException. I'll update the commit with your change

[avanderhoorn]

@nikmd23 are we good to pull this one in?

[jeffora]

Closing this as I don't think it's relevant anymore leading into v1.0

[rancomarcus]

@jeffora Could you please clarify your last comment? Is a new release imminent? The generated NullReferenceExceptions are really messing up the debugging experience.

[jeffora]

There's definitely one in the pipeline, although I'm not sure how close it is to being done. It's a fairly hefty rewrite, so this small change doesn't seem relevant moving forward. @avanderhoorn or @nikmd23 might be able to give more information