Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make Glimpse check if things are enabled in DataBoundControlAdapter (fix for #779) #789
When Glimpse is enabled and then disabled the DataBoundControlAdapter is still registered but GlimpseConfiguration.GetConfiguredTimerStrategy()() returns null. Defensive checks added so event listeners only added when Glimpse enabled.
referenced this pull request
Apr 29, 2014
@grahammendick thanks for the fix. Maybe you already had the issue with the adapter not registering during setup while developing the feature and that that is why it is now part of the GetData method, so no worries there
I see what you mean, as it is an instance property and not statically accessible (but that has been fixed in v2
Just wondering why you also changed the reflection parts aka from
The reflection change was fixing my earlier sloppy paste from the PageAdapter. It worked fine because PageAdapter inherits from ControlAdapter but it was misleading because the DataBoundControlAdapter didn't inherit from PageAdapter.