Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Glimpse breaks AWS-SDK S3 calls #113

Closed
chriskinsman opened this issue May 19, 2017 · 4 comments
Closed

Glimpse breaks AWS-SDK S3 calls #113

chriskinsman opened this issue May 19, 2017 · 4 comments

Comments

@chriskinsman
Copy link

var AWS = require('aws-sdk');
var s3 = new AWS.S3({accessKeyId: config.AWSACCESSKEYID, secretAccessKey: config.AWSSECRETACCESSKEY, region: config.AWSREGION});

s3.getObject({
        Bucket:bucket,
        Key: prefix + '/' + key
    }, function(err, data) {

--> Without glimpse installed data.body is a UInt8Array with a length that matches content. With glimpse installed the array is always empty. i.e. retrieving an object from S3 fails

});

@mike-kaufman
Copy link
Contributor

Thanks For reporting this @chriskinsman. We'll look into it...

@philliphoff
Copy link
Contributor

Thanks for submitting the issue, @chriskinsman! We've been able to reproduce the problem and have a pretty good idea of what's happening; it looks like our interception of the response data for Glimpse reporting purposes is interfering with aws-sdk's management of the response data. We'll work on a fix and let you know when it's available in an upcoming release.

@avanderhoorn
Copy link
Member

It looks like we have a solution and are currently doing some testing to make sure we have gotten all the edge cases we can see. Hopefully this will get in the upcoming release. We will let you know how testing goes! Thanks again.

@mike-kaufman
Copy link
Contributor

Fix for this is availabe on NPM now with glimpse version 0.21.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants