Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

NullPointerException in ParametersManager #2

Closed
sczerwinski opened this issue Dec 26, 2015 · 2 comments
Closed

NullPointerException in ParametersManager #2

sczerwinski opened this issue Dec 26, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@sczerwinski
Copy link
Member

If there is a problem with finding a proper converter, NullPointerException is thrown at ParametersManager.findConverter().

private ParameterConverter<?> findConverter(Object rawValue) {
    ParameterConverter<?> converter = null;
    for (Class<?> cls = rawValue.getClass(); converter == null; cls = cls.getSuperclass()) { // <-- NullPointerException
        converter = converters.get(cls);
    }
    return converter;
}

An exception indicating a real cause should be thrown instead.

@sczerwinski sczerwinski added this to the 0.2 milestone Dec 26, 2015
@sczerwinski sczerwinski self-assigned this Dec 26, 2015
@sczerwinski
Copy link
Member Author

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
    at org.glimpseframework.internal.shader.parameters.ParametersManager.findConverter(ParametersManager.java:78)
    at org.glimpseframework.internal.shader.parameters.ParametersManager.applyParameter(ParametersManager.java:72)
    at org.glimpseframework.internal.shader.parameters.ParametersManager.applyParameters(ParametersManager.java:66)
    at org.glimpseframework.api.Scene.renderModel(Scene.java:114)
    at org.glimpseframework.api.Scene.doRender(Scene.java:101)
    at org.glimpseframework.api.Scene.render(Scene.java:88)
    at org.glimpseframework.android.AndroidScene.onDrawFrame(AndroidScene.java:58)
    at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1535)
    at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1240)

sczerwinski added a commit that referenced this issue Feb 21, 2016
@sczerwinski
Copy link
Member Author

null parameter is now handled by NullConverter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

1 participant