Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip .svn subdirectory #491

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Skip .svn subdirectory #491

merged 2 commits into from
Jan 30, 2023

Conversation

doctaweeks
Copy link
Contributor

Older SVN versions will create a .svn subdirectory in each directory of the repo. If one is present in the RepositoryPath, skip it, otherwise it will be removed, damaging the repo.

Older SVN versions will create a .svn subdirectory in each directory of the
repo. If one is present in the RepositoryPath, skip it, otherwise it will be
removed, damaging the repo.
@JoC0de
Copy link
Collaborator

JoC0de commented Jan 29, 2023

The RepositoryPath is the folder where all nuget packages are installed, so it is a folder that is created and managed by a Package Manager. So it shouldn't be pushed to a version control system like GIT or SVN. And when you don't push it you should not have the problem. Or am I wrong?

@doctaweeks
Copy link
Contributor Author

You are correct, if it not checked in, then it won't be a problem. However, there are reasons to check packages in, for example:

  • Builds where there is no network access
  • Reduce external dependencies in a build pipeline
  • Cut down first build time on a fresh checkout

src/NuGetForUnity/Editor/NugetHelper.cs Outdated Show resolved Hide resolved
@JoC0de
Copy link
Collaborator

JoC0de commented Jan 29, 2023

Ok you are right. If you 'apply' my suggestion I will merge it.

Co-authored-by: JoC0de <53140583+JoC0de@users.noreply.github.com>
@JoC0de JoC0de merged commit ab764d2 into GlitchEnzo:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants