Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore improvements #541

Merged
merged 11 commits into from Jul 28, 2023
Merged

Restore improvements #541

merged 11 commits into from Jul 28, 2023

Conversation

popara96
Copy link
Collaborator

Fixed installing older versions of package when reloading from older package.config and added automatic restore when packages.config changes. Also fixed updating packages.

@popara96 popara96 requested review from igor84 and JoC0de July 20, 2023 15:19
@popara96 popara96 requested a review from JoC0de July 24, 2023 12:44
src/NuGetForUnity.Tests/Assets/Tests/Editor/NuGetTests.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/NugetHelper.cs Outdated Show resolved Hide resolved
@popara96 popara96 requested a review from JoC0de July 26, 2023 08:47
@popara96
Copy link
Collaborator Author

The timeouts that happen seem to be related to this bug. I'm not sure what we can do with it except update Unity version, but we also modified the tests a bit in hopes to fix them.

@popara96 popara96 requested a review from JoC0de July 27, 2023 13:33
@JoC0de
Copy link
Collaborator

JoC0de commented Jul 27, 2023

The timeouts that happen seem to be related to this bug. I'm not sure what we can do with it except update Unity version, but we also modified the tests a bit in hopes to fix them.

It is strange that it only happens since I added the Local Package Hierarchy restore tests. I didn't update the unity version used in the Action.

@popara96
Copy link
Collaborator Author

@JoC0de we don't know for sure what causes this issue as it doesn't happen every time, but it seems that neither your nor my changes have anything to do with it. As for Unity 2018, the link I sent says that it is fixed in version 2018.4.35f1 (we're currently on 2018.4.30f1), so we might consider upgrading to at least that one, but it still does not guarantee the issue will disappear.

@popara96 popara96 merged commit ce4df2e into master Jul 28, 2023
8 checks passed
@popara96 popara96 deleted the restore-improvements branch July 28, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants