New basemap #90
Merged
New basemap #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleting instances temporalgrid-demo! Give me a second Deleted successfully. |
🦋 Changeset detectedLatest commit: 08a9236 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
j8seangel
approved these changes
Sep 25, 2020
j8seangel
reviewed
Sep 25, 2020
| @@ -65,7 +65,7 @@ export interface BasemapGeneratorConfig extends GeneratorConfig { | |||
| /** | |||
| * Sets the color of the map background in any format supported by Mapbox GL, see https://docs.mapbox.com/mapbox-gl-js/style-spec/types/#color | |||
| */ | |||
| basemap?: string | |||
| basemap: BasemapType | |||
There was a problem hiding this comment.
I think we could leave it as optional because we already have a default configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new basemap composed of bathymetry + landmass + graticules
Full basemap for future dev including countries/regions/ports is stored here:
https://github.com/GlobalFishingWatch/basemap