-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline component #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👍
We need to add clearer documentation to the README:
- how to initialize and use the sandbox
- brief description of what does each component
@@ -3,10 +3,10 @@ | |||
"version": "0.1.0", | |||
"private": true, | |||
"dependencies": { | |||
"@globalfishingwatch/map-components": "link:..", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
@@ -1 +1,5 @@ | |||
export { default as MiniGlobe } from './miniglobe/miniglobe' | |||
export { default as Timebar } from './timebar/Timebar' | |||
export { default as TimebarActivity } from './timebar/charts/Activity' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure about that. I'd rather being able to do
import Timebar from '@globalfishingwatch/map-components'
import { VesselEvents } from '@globalfishingwatch/map-components/timebarCharts'
than
import {
Timebar,
VesselEvents
} from '@globalfishingwatch/map-components'
…p-components into timeline-component * 'timeline-component' of github.com:GlobalFishingWatch/map-components: clarify docs
Added components description and uglify dist code to make it lighter in production. |
Moving time bar component to this repo #1
Nice to think about:
peerDependencies
.